Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Grover change #421

Merged
merged 7 commits into from
May 25, 2021
Merged

Small Grover change #421

merged 7 commits into from
May 25, 2021

Conversation

igres26
Copy link
Contributor

@igres26 igres26 commented May 24, 2021

Changed the Grover model where the iterative model always outputs something even if it runs for too long of a time.

@igres26 igres26 requested a review from stavros11 May 24, 2021 14:51
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #421 (588e25d) into master (3b61c09) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #421   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           79        79           
  Lines        11399     11401    +2     
=========================================
+ Hits         11399     11401    +2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/tests/test_parallel.py 100.00% <ø> (ø)
src/qibo/models/grover.py 100.00% <100.00%> (ø)
src/qibo/parallel.py 100.00% <100.00%> (ø)
src/qibo/tests/test_models_grover.py 100.00% <100.00%> (ø)
src/qibo/tests/test_models_variational.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b61c09...588e25d. Read the comment docs.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, thanks.

@scarrazza scarrazza merged commit e43aa65 into master May 25, 2021
@scarrazza scarrazza deleted the grover-changes branch July 10, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants