-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove matmuleinsum backend #404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stavros11 thank you, looks pretty good.
Please above minor comments.
Codecov Report
@@ Coverage Diff @@
## simtf #404 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 76 76
Lines 12401 12265 -136
==========================================
- Hits 12401 12265 -136
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks for the fixes, I checked using the I will continue working on the points you wrote in #398 and particularly bring all the tests in the |
As discussed in #398 this removes the matmuleinsum backend and renames the existing backends as follows:
np.einsum
withtf.einsum
.