Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove matmuleinsum backend #404

Merged
merged 21 commits into from
May 4, 2021
Merged

Remove matmuleinsum backend #404

merged 21 commits into from
May 4, 2021

Conversation

stavros11
Copy link
Member

As discussed in #398 this removes the matmuleinsum backend and renames the existing backends as follows:

  • qibotf: The old custom backend which now loads the custom operators from the external qibotf library.
  • numpy: The numpy defaulteinsum backend.
  • tensorflow: The old defaulteinsum backend which uses the numpy implementation replacing np.einsum with tf.einsum.

@stavros11 stavros11 requested a review from scarrazza May 3, 2021 17:49
Copy link
Member

@scarrazza scarrazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stavros11 thank you, looks pretty good.
Please above minor comments.

@codecov
Copy link

codecov bot commented May 4, 2021

Codecov Report

Merging #404 (fc9dffd) into simtf (8cdcdcd) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             simtf      #404    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           76        76            
  Lines        12401     12265   -136     
==========================================
- Hits         12401     12265   -136     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/backends/__init__.py 100.00% <100.00%> (ø)
src/qibo/backends/abstract.py 100.00% <100.00%> (ø)
src/qibo/backends/einsum_utils.py 100.00% <100.00%> (ø)
src/qibo/backends/numpy.py 100.00% <100.00%> (ø)
src/qibo/backends/tensorflow.py 100.00% <100.00%> (ø)
src/qibo/core/circuit.py 100.00% <100.00%> (ø)
src/qibo/core/distcircuit.py 100.00% <100.00%> (ø)
src/qibo/core/fusion.py 100.00% <100.00%> (ø)
src/qibo/core/gates.py 100.00% <100.00%> (ø)
src/qibo/models/variational.py 100.00% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cdcdcd...fc9dffd. Read the comment docs.

@stavros11
Copy link
Member Author

Thanks for the fixes, I checked using the test_prints.py script and I think there aren't any leftover "defaulteinsum" and "matmuleinsum" references in the source code or the examples.

I will continue working on the points you wrote in #398 and particularly bring all the tests in the tests_new format.

@scarrazza scarrazza merged commit 4e2ef6a into simtf May 4, 2021
@stavros11 stavros11 deleted the matmuleinsum branch May 5, 2021 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants