Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving distributed circuit into core #395

Merged
merged 6 commits into from
Apr 29, 2021
Merged

moving distributed circuit into core #395

merged 6 commits into from
Apr 29, 2021

Conversation

scarrazza
Copy link
Member

Moving the distributed circuit into core.

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #395 (acf7c19) into master (8a41754) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #395   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           80        80           
  Lines        12731     12731           
=========================================
  Hits         12731     12731           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/core/distutils.py 100.00% <ø> (ø)
src/qibo/models/evolution.py 100.00% <ø> (ø)
src/qibo/models/variational.py 100.00% <ø> (ø)
...m_operators/python/ops/qibo_tf_custom_operators.py 100.00% <ø> (ø)
src/qibo/core/distcircuit.py 100.00% <100.00%> (ø)
src/qibo/core/states.py 100.00% <100.00%> (ø)
src/qibo/models/circuit.py 100.00% <100.00%> (ø)
src/qibo/tests/test_distributed.py 100.00% <100.00%> (ø)
src/qibo/tests_new/test_core_states_distributed.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a41754...acf7c19. Read the comment docs.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving this and fixing the docs. I pushed an additional fix for the docs as some qibo.tensorflow.distcircuit were remaining in advancedexamples.rst. Other than that I believe it is good to merge.

@scarrazza
Copy link
Member Author

@stavros11 thanks.

@scarrazza scarrazza merged commit b99568a into master Apr 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the distsort branch April 29, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants