Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing undesired prints #387

Merged
merged 1 commit into from
Apr 16, 2021
Merged

removing undesired prints #387

merged 1 commit into from
Apr 16, 2021

Conversation

scarrazza
Copy link
Member

Closes #386. I don't think there is some simple way to catch prints from pytest but let me know.

Copy link
Contributor

@bpcarlos bpcarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the undesired prints

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #387 (acb855c) into master (db9b794) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #387   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           77        77           
  Lines        12454     12450    -4     
=========================================
- Hits         12454     12450    -4     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/core/gates.py 100.00% <ø> (ø)
...qibo/tests_new/test_tensorflow_custom_operators.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db9b794...acb855c. Read the comment docs.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a quick look too and did not find any other prints.

Closes #386. I don't think there is some simple way to catch prints from pytest but let me know.

I am also not aware of any method to do this directly with pytest. A naive solution would be to write a test that loads each .py file from the project as string and checks if it contains the word print, excluding the cases where print appears in docstrings. If you agree I can try to implement this test in a different PR.

@scarrazza
Copy link
Member Author

@stavros11 ok, let's do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set_parameters returns prints
3 participants