Use single gates.py file for all backends #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## tfmem #372 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 78 77 -1
Lines 12724 12426 -298
==========================================
- Hits 12724 12426 -298
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
scarrazza
reviewed
Apr 5, 2021
| def __init__(self): | ||
| super().__init__() | ||
| self.gates = tuple() | ||
| # create inversion gates to rest to the original state vector |
scarrazza
reviewed
Apr 5, 2021
scarrazza
reviewed
Apr 5, 2021
There was a problem hiding this comment.
@stavros11 thanks for this cleanup, the code is much simpler to follow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies our code base by removing the
cgates.pyfile and using a single file to implement gates for all different backends. To do so, I moved the functions that apply gates (state_vector_callanddensity_matrix_call) to the backends. As discussed in #363 I also removed theprepareandrepreparemethods from gates as they are not needed anymore.I tested the multi-GPU performance of this branch and it is the same as master so there is no fix required for that regard. The memory and performance for very deep circuits is also the same with what reported in #363.