Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating multiline circuit draw #354

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Updating multiline circuit draw #354

merged 1 commit into from
Mar 16, 2021

Conversation

scarrazza
Copy link
Member

Closes #353. @igres26 could you please give a try and let me know if you like it?

@scarrazza scarrazza requested a review from igres26 March 16, 2021 10:38
Copy link
Contributor

@igres26 igres26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this. The extra qubit labels work as I asked, and make the circuit more easily interpreted. I am still unsure if 70 is the correct line_wrap for most users but it looks good on my end. Could probably push it to 75 or 80, but that will depend on the user, so I think its fine.

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #354 (452de4b) into master (f45dd66) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #354   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           76        76           
  Lines        12468     12473    +5     
=========================================
+ Hits         12468     12473    +5     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/tests_new/test_abstract_circuit.py 100.00% <ø> (ø)
src/qibo/abstractions/circuit.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f45dd66...452de4b. Read the comment docs.

@scarrazza scarrazza merged commit 34bd341 into master Mar 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the empdraw branch March 16, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements on drawing circuits.
2 participants