Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warning, remove old draw, and rename display as draw in Circuit class #1464

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Sep 24, 2024

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added this to the Qibo 0.2.13 milestone Sep 24, 2024
@renatomello renatomello added the enhancement New feature or request label Sep 24, 2024
@renatomello renatomello self-assigned this Sep 24, 2024
@alecandido
Copy link
Member

@renatomello is it here because you want to have it directly in the next release, or is it here just not to forget?

In principle, we should collect breaking changes for 0.3. I would agree that we may be a bit more lenient, but just one/two months after seems a very short notice (especially given the amount of time .draw() has been there since...).

@renatomello
Copy link
Contributor Author

@renatomello is it here because you want to have it directly in the next release, or is it here just not to forget?

In principle, we should collect breaking changes for 0.3. I would agree that we may be a bit more lenient, but just one/two months after seems a very short notice (especially given the amount of time .draw() has been there since...).

The current warning says the change would happen in 0.2.13.

@alecandido
Copy link
Member

The current warning says the change would happen in 0.2.13.

Ok, I've not been careful in reviewing that...

It's a small thing, and updating broken third-party code because of that won't be a massive effort. We can make an exception...

Still, I'd like to increasingly improve our stability guarantees. We should definitely lower the number of semver exceptions abruptly, getting to zero as fast as possible...

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (68bdb98) to head (f99b52a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1464   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          81       81           
  Lines       11740    11737    -3     
=======================================
- Hits        11733    11731    -2     
+ Misses          7        6    -1     
Flag Coverage Δ
unittests 99.94% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello marked this pull request as ready for review September 25, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants