Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding qulacs to extra #1410

Merged
merged 1 commit into from
Aug 3, 2024
Merged

Adding qulacs to extra #1410

merged 1 commit into from
Aug 3, 2024

Conversation

scarrazza
Copy link
Member

@scarrazza scarrazza commented Aug 3, 2024

Closes #1409.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@scarrazza scarrazza changed the title adding qulacs to extra Adding qulacs to extra Aug 3, 2024
Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should have been an extra from the beginning, sorry.

@alecandido
Copy link
Member

Apparently, tests are randomly failing (they were all because of numerical values). I'm rerunning them, but that's an issue on its own.
https://github.com/qiboteam/qibo/actions/runs/10226346562/attempts/1?pr=1410

@scarrazza
Copy link
Member Author

I think this is due to the torch version update. If I don't update the lock file, tests are passing: https://github.com/qiboteam/qibo/actions/runs/10226488301. I will probably revert the torch update.

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (64d78bc) to head (9f1f3dd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1410   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          78       78           
  Lines       11222    11222           
=======================================
  Hits        11216    11216           
  Misses          6        6           
Flag Coverage Δ
unittests 99.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scarrazza scarrazza merged commit 6d67625 into master Aug 3, 2024
27 checks passed
@alecandido alecandido deleted the fixqulacsdeps branch August 28, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qulacs is always a dependency
3 participants