Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding code of conduct #1387

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Adding code of conduct #1387

merged 1 commit into from
Jul 10, 2024

Conversation

scarrazza
Copy link
Member

@scarrazza scarrazza commented Jul 10, 2024

Including a code of conduct before elaborating the contributing guidelines.

Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scarrazza, LGTM.
For contributors shall we add also a CONTRIBUTING.md?
EDIT: I just read that you are planning to do that later, nevermind.

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (98a310a) to head (dea07f4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1387   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          76       76           
  Lines       10844    10844           
=======================================
  Hits        10827    10827           
  Misses         17       17           
Flag Coverage Δ
unittests 99.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scarrazza
Copy link
Member Author

@andrea-pasquale I will open another PR for that. @alecandido I will have a look. Are you suggesting to use that instead as template?

@alecandido
Copy link
Member

@alecandido I will have a look. Are you suggesting to use that instead as template?

Nono, that's exactly the template you used. I just took a look at the website, and they were suggesting to list yourself in their adopters. Not sure we want to go through the burden (i.e. just a PR adding a line to a CSV), but I posted just in case.

@scarrazza
Copy link
Member Author

@alecandido I will have a look. Are you suggesting to use that instead as template?

Nono, that's exactly the template you used. I just took a look at the website, and they were suggesting to list yourself in their adopters. Not sure we want to go through the burden (i.e. just a PR adding a line to a CSV), but I posted just in case.

Sure, I will have a look.

@scarrazza scarrazza merged commit 3bfd433 into master Jul 10, 2024
28 checks passed
@scarrazza scarrazza deleted the codeofconduct branch July 20, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants