Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBI Hotfix #1343

Merged
merged 12 commits into from
Jun 12, 2024
Merged

DBI Hotfix #1343

merged 12 commits into from
Jun 12, 2024

Conversation

Edoardo-Pedicillo
Copy link
Contributor

Restore eval_dbr_unitary
Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

andrea-pasquale
andrea-pasquale approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Edoardo-Pedicillo, I confirm that now boostvqe is working as expected.

src/qibo/models/variational.py Outdated Show resolved Hide resolved
src/qibo/models/variational.py Outdated Show resolved Hide resolved
src/qibo/models/dbi/double_bracket.py Outdated Show resolved Hide resolved
Edoardo-Pedicillo and others added 2 commits June 6, 2024 16:11
@Edoardo-Pedicillo @andrea-pasquale
Update src/qibo/models/variational.py
813a306 
Co-authored-by: Andrea Pasquale <andreapasquale97@gmail.com>
@Edoardo-Pedicillo @andrea-pasquale
Apply suggestions from code review
3994a90 
Co-authored-by: Andrea Pasquale <andreapasquale97@gmail.com>
@MatteoRobbiati MatteoRobbiati self-requested a review June 6, 2024 12:14
@codecov Codecov
Copy link

codecov bot commented Jun 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (8dd1d33) to head (a8f453b).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1343   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          74       74           
  Lines       10753    10758    +5     
=======================================
+ Hits        10736    10741    +5     
  Misses         17       17
Flag Coverage Δ
unittests 99.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MatteoRobbiati
MatteoRobbiati approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

src/qibo/models/dbi/double_bracket.py Outdated Show resolved Hide resolved
@andrea-pasquale @MatteoRobbiati
doc: Update docstring
a8f453b 
Co-authored-by: Matteo Robbiati <62071516+MatteoRobbiati@users.noreply.github.com>
@Edoardo-Pedicillo Edoardo-Pedicillo added this pull request to the merge queue Jun 12, 2024
Merged via the queue into master with commit 5676a8a Jun 12, 2024
27 checks passed
@scarrazza scarrazza deleted the restore_dbi_call branch June 25, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrea-pasquale andrea-pasquale andrea-pasquale approved these changes

@MatteoRobbiati MatteoRobbiati MatteoRobbiati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Edoardo-Pedicillo @andrea-pasquale @MatteoRobbiati