Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc deployment by moving torch import #1281

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Conversation

Simone-Bordoni
Copy link
Contributor

@Simone-Bordoni Simone-Bordoni commented Mar 21, 2024

Remove torch import at the beginning of the pytorch backend to fix test in contructing the documentation. Also improved the conversion to pytorch dtype.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@Simone-Bordoni Simone-Bordoni added the bug Something isn't working label Mar 21, 2024
@Simone-Bordoni Simone-Bordoni self-assigned this Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (8fd5657) to head (e249e85).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1281   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          73       73           
  Lines       10690    10694    +4     
=======================================
+ Hits        10674    10678    +4     
  Misses         16       16           
Flag Coverage Δ
unittests 99.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello changed the title Fix torch import Fix doc deployment by moving torch import Mar 22, 2024
@renatomello renatomello added this to the Qibo 0.2.7 milestone Mar 22, 2024
@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi added this pull request to the merge queue Mar 28, 2024
Merged via the queue into master with commit cb60314 Mar 28, 2024
21 checks passed
@scarrazza scarrazza deleted the fix_import branch June 25, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants