Qcnn docs #1275
Merged
Qcnn docs #1275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1275 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 73 73
Lines 10638 10638
=======================================
Hits 10632 10632
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MatteoRobbiati
approved these changes
Apr 3, 2024
Comment on lines
+68
to
+71
| nclasses (int, optional): The number of classes for the classification task. Defaults to 2. | ||
| params (np.ndarray, optional): The initial parameters for the QCNN. If None, random parameters are generated. Defaults to None. | ||
| twoqubitansatz (qibo.models.circuit.Circuit, optional): A two-qubit ansatz for the convolutional layers. If None, a default ansatz is used. Defaults to None. | ||
| copy_init_state (bool, optional): Whether to copy the initial state for each shot in the simulation. If None, the behavior depends on the backend. Defaults to None. |
There was a problem hiding this comment.
Fine also with this notation, but if you want you can use the [typing] python module:
from typing import Optional
def function(nqubits: int, ..., copy_init_state: Optional[bool] = None){
...
}
scarrazza
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated some docstrings in the QCNN class.
Checklist: