Simplified _Queue append
#1255
Merged
Simplified _Queue append
#1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1255 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 72 72
Lines 10454 10454
=======================================
Hits 10449 10449
Misses 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
stavros11
reviewed
Mar 8, 2024
|
Thanks @stavros11, made them properties once again. |
renatomello
reviewed
Mar 11, 2024
renatomello
reviewed
Mar 11, 2024
| @property | ||
| def moments(self): | ||
| moments = [self.nqubits * [None]] | ||
| moment_index = self.nqubits * [0] |
There was a problem hiding this comment.
Before, users had access to moment_index and now they don't. I don't know if this is the intended behaviour or not.
renatomello
approved these changes
Mar 11, 2024
renatomello
reviewed
Mar 11, 2024
| return len([1 for gate in self if isinstance(gate, gates.M)]) | ||
|
|
||
| @property | ||
| def moments(self): |
There was a problem hiding this comment.
Both properties are missing docstrings
Co-authored-by: Renato Mello <renato.msf@gmail.com>
renatomello
reviewed
Mar 11, 2024
stavros11
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
qibo.models.Circuit._Queue.append()method that was overloading thelist.append(). The generation of the moments and the calculation of the number of measurements in the circuit is therefore delayed to when it's actually needed. This was mainly motivated by therandom_cliffordfunction that appends a lot of gates to the circuit, but I believe it is in general useful for speeding up all the functions that make heavily use of theCircuit.add()method, even though the difference in most cases is probably negligible.Checklist: