Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cuquantum test bug in test_backends_clifford.py #1236

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Feb 29, 2024

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added bug Something isn't working quantum_info module PRs and issues related to the quantum information module labels Feb 29, 2024
@renatomello renatomello added this to the Qibo 0.2.5 milestone Feb 29, 2024
@renatomello renatomello self-assigned this Feb 29, 2024
@alecandido
Copy link
Member

@renatomello I'd say that a better fix would be to decouple the Clifford engine from the other backends.
By now, it is not really reusing anything of the backends. So, I'd just parametrize tests on engine, and spell out which are the available engines.

However, if you prefer to have this immediately in master as a hotfix, I have nothing against it.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7190eae) to head (e8585d4).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1236   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           72        72           
  Lines        10480     10480           
=========================================
  Hits         10480     10480           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello added this pull request to the merge queue Feb 29, 2024
Merged via the queue into master with commit 31bbbb4 Feb 29, 2024
24 of 25 checks passed
@renatomello renatomello deleted the cuquantum_test branch February 29, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quantum_info module PRs and issues related to the quantum information module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants