Split star transpiler into placer and router pass #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simone-Bordoni
requested review from
BrunoLiegiBastonLiegi,
stavros11 and
renatomello
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1156 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 68 67 -1
Lines 9906 9906
=========================================
Hits 9906 9906
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
renatomello
reviewed
Jan 24, 2024
renatomello
approved these changes
Jan 24, 2024
|
I get an error from Codecov, however when i check the details it says that all lines are covered by tests. Any ideas what may the problem be? |
BrunoLiegiBastonLiegi
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows to uniform star transpiler with all the other transpiler steps. This should simplify the transpiling pipeline and make the code manteinance easier.
Checklist: