Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increasing doctest speed #1148

Merged
merged 2 commits into from
Dec 21, 2023
Merged

increasing doctest speed #1148

merged 2 commits into from
Dec 21, 2023

Conversation

scarrazza
Copy link
Member

@scarrazza scarrazza commented Dec 21, 2023

I was debugging doctest when I realized that testsetup was not fixing the backend properly. I have changed this call to testcode and performance has improved a lot. We can reduce the requirements for examples (e.g. nqubits, epochs, shots) however the impact is not relevant in comparison to the small change applied in this branch.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@scarrazza scarrazza changed the base branch from master to fixcupy December 21, 2023 13:22
@scarrazza scarrazza added this to the Qibo 0.2.4 milestone Dec 21, 2023
@scarrazza scarrazza linked an issue Dec 21, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf299a6) 100.00% compared to head (343cba4) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           fixcupy     #1148   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           67        67           
  Lines         9588      9588           
=========================================
  Hits          9588      9588           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scarrazza

@scarrazza scarrazza merged commit 19adef4 into fixcupy Dec 21, 2023
21 checks passed
@scarrazza scarrazza deleted the fixdoctest branch January 12, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce tests duration
2 participants