Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagonal architectute to deterministic Unary encoder #1141

Merged
merged 13 commits into from
Jan 12, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Dec 19, 2023

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f53ddc) 100.00% compared to head (8e96b46) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1141   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           68        68           
  Lines         9777      9801   +24     
=========================================
+ Hits          9777      9801   +24     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello changed the title Add diagonal and semi-diagonal architectutes to Unary encoder Add diagonal architectute to Unary encoder Dec 19, 2023
@renatomello renatomello added this to the Qibo 0.2.4 milestone Dec 19, 2023
@renatomello renatomello added the enhancement New feature or request label Dec 19, 2023
@renatomello renatomello marked this pull request as ready for review December 19, 2023 14:27
@renatomello renatomello changed the title Add diagonal architectute to Unary encoder Add diagonal architectute to deterministic Unary encoder Dec 20, 2023
@renatomello renatomello added the documentation Improvements or additions to documentation label Dec 21, 2023
[(index, index + int(nqubits / 2**depth)) for index in indexes]
]
pairs_rbs += pairs_rbs_per_depth
indexes = list(np.array(pairs_rbs_per_depth).flatten())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
indexes = list(np.array(pairs_rbs_per_depth).flatten())
indexes = list(np.array(pairs_rbs_per_depth).ravel())

@renatomello renatomello added this pull request to the merge queue Jan 12, 2024
Merged via the queue into master with commit f05a722 Jan 12, 2024
21 checks passed
@renatomello renatomello deleted the unary_architecture branch January 12, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants