Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to circuit wires #1134

Merged
merged 12 commits into from
Jan 10, 2024
Merged

Add labels to circuit wires #1134

merged 12 commits into from
Jan 10, 2024

Conversation

Simone-Bordoni
Copy link
Contributor

@Simone-Bordoni Simone-Bordoni commented Dec 12, 2023

Solve issue #1130

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@Simone-Bordoni Simone-Bordoni added the enhancement New feature or request label Dec 12, 2023
@Simone-Bordoni Simone-Bordoni self-assigned this Dec 12, 2023
@Simone-Bordoni Simone-Bordoni linked an issue Dec 12, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0eeb6ae) 100.00% compared to head (fd42286) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1134   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           67        67           
  Lines         9588      9611   +23     
=========================================
+ Hits          9588      9611   +23     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello added this to the Qibo 0.2.4 milestone Dec 13, 2023
@renatomello renatomello changed the title wires names Add labels to circuit wires Dec 13, 2023
@renatomello
Copy link
Contributor

This is almost ready. Coverage probably still needs to be fixed. But most importantly, this functionality should be integrated with Circuit.light_cone before merging.

@Simone-Bordoni
Copy link
Contributor Author

This is almost ready. Coverage probably still needs to be fixed. But most importantly, this functionality should be integrated with Circuit.light_cone before merging.

Ok, can you update it for the light cone? Cause I also need this functionality for the transpiler but first I need this and #1121

@renatomello renatomello added the documentation Improvements or additions to documentation label Dec 16, 2023
@MatteoRobbiati MatteoRobbiati added this pull request to the merge queue Jan 10, 2024
Merged via the queue into master with commit 374f743 Jan 10, 2024
21 checks passed
@stavros11 stavros11 deleted the wires_names branch January 10, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wires names
4 participants