-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add probabilities
to MeasurementOutcomes
#1066
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1066 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 8835 8857 +22
=========================================
+ Hits 8835 8857 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@BrunoLiegiBastonLiegi did you test this on hardware? |
Not yet, I am going to test it asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BrunoLiegiBastonLiegi, looks good to me. The comments are not really blocking, although I would give a try to lower the tolerance in the test.
I also have not tested on hardware (will test the qibolab PR soon), but I don't the current PR is breaking anything since you are just calculating the probabilities from frequencies, and it shouldn't make a difference if the frequencies are simulated or obtained from hardware.
Ok, I made a quick test on the hardware and the calculation of the probabilities from the frequencies works. |
Ok I have added the qubits parameter and tested on hardware. It seems to work fine up to the calibration of the qubits. |
Co-authored-by: Renato Mello <renato.msf@gmail.com>
Co-authored-by: Renato Mello <renato.msf@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Renato Mello <renato.msf@gmail.com>
Co-authored-by: Renato Mello <renato.msf@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Renato Mello <renato.msf@gmail.com>
Co-authored-by: Renato Mello <renato.msf@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Renato Mello <renato.msf@gmail.com>
Co-authored-by: Renato Mello <renato.msf@gmail.com>
Co-authored-by: Renato Mello <renato.msf@gmail.com>
Co-authored-by: Renato Mello <renato.msf@gmail.com>
Co-authored-by: Renato Mello <renato.msf@gmail.com>
Co-authored-by: Renato Mello <renato.msf@gmail.com>
Co-authored-by: Renato Mello <renato.msf@gmail.com>
Co-authored-by: Renato Mello <renato.msf@gmail.com>
Co-authored-by: Renato Mello <renato.msf@gmail.com>
probabilities
to MeasurementOutcomes
Tiny patch to #1039 that implements the calculation of the probabilities starting from the frequencies in
MeasurementOutcomes
objects.Checklist: