Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable not defined in mpldrawer #1437

Closed
renatomello opened this issue Sep 5, 2024 · 5 comments · Fixed by #1438, #1338 or #1444
Closed

Variable not defined in mpldrawer #1437

renatomello opened this issue Sep 5, 2024 · 5 comments · Fixed by #1438, #1338 or #1444
Labels
bug Something isn't working

Comments

@renatomello
Copy link
Contributor

renatomello commented Sep 5, 2024

@MatteoRobbiati @sergiomtzlosa

PR #1370 introduced the new ui module to master. There is a helper function in the module that is raising a lint error due to an undefined variable. The specific line is this one. This is preventing tests from passing, e.g. https://github.com/qiboteam/qibo/actions/runs/10715691273/job/29711648870

@renatomello renatomello added the bug Something isn't working label Sep 5, 2024
@MatteoRobbiati
Copy link
Contributor

Thanks for spotting this! @sergiomtzlosa, should we pass the circuit as an argument so that we keep that line or do you think we can do that in a different way?

sergiomtzlosa added a commit to sergiomtzlosa/qibo that referenced this issue Sep 5, 2024
@sergiomtzlosa
Copy link
Contributor

sergiomtzlosa commented Sep 5, 2024

sorry @renatomello and @MatteoRobbiati ! I did not spot this, I just submit a commit to fix this bug

@alecandido
Copy link
Member

alecandido commented Sep 5, 2024

Yeah, unfortunately we didn't notice because the CI was not running, since the PR came from a fork.

However, this should not happen for new PRs, even from forks. If that's not the case, please report it to me or @scarrazza

@MatteoRobbiati
Copy link
Contributor

sorry @renatomello and @MatteoRobbiati ! I did not spot this, I just submit a commit to fix this bug

No problem. Are you going to open a PR for this?

@sergiomtzlosa
Copy link
Contributor

yes! here is the pull request #1438

@renatomello renatomello linked a pull request Sep 9, 2024 that will close this issue
4 tasks
@MatteoRobbiati MatteoRobbiati linked a pull request Sep 11, 2024 that will close this issue
4 tasks
@renatomello renatomello linked a pull request Sep 11, 2024 that will close this issue
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants