Split platform specific code to its own file #21368
Open
+240
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chocobo1
added
the
Code cleanup
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
glassez
reviewed
Sep 20, 2024
| #include <cstring> | ||
| #include <sys/random.h> | ||
| #if defined(Q_OS_LINUX) | ||
| #include "randomlayer_linux.cpp" |
There was a problem hiding this comment.
I would still use .h extension for these files.
Nevermind. I'm not sure.
There was a problem hiding this comment.
But they have different private fields and the header will become 'dirty' if all platform specific code are in there.
There was a problem hiding this comment.
I mean "randomlayer_linux.h" etc.
But it looks strange because of unnamed namespace there.
There was a problem hiding this comment.
I mean "randomlayer_linux.h" etc.
Then the header will contain implementations which we previously keep it in .cpp files.
It seems to me, doing it other way will not be as clean as the current.
glassez
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.