[Update] Disabled Option #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ItsANoBrainer
commented
Feb 25, 2022
•
ItsANoBrainer
commented
- Reworked .js code to work off of event listeners instead of trying to find the button based off every single document click
- Added support for the "disabled" option parameter, takes a bool, when true you can't click on it
- Disabled entry has a greyed out background
- Added underline to header menu entry
- Reworked .js code to work off of event listeners instead of trying to find the button based off every single document click - Added support for the "disabled" option parameter, takes a bool, when true you can't click on it - Disabled entry has a greyed out background - Added underline to header menu entry
|
Did you test everything? Including return values? |
|
Yes I've been using this for a month or so. |
|
actually, we need it to shorten instead of having to create multiple menus , nice work |
- Doesnt even create/render the option. Can be used instead of disable option
@xenfovn It is easier to do this and set it to a dynamically changing bool instead of dynamically creating the table based on that variable. |
FjamZoo
approved these changes
Apr 2, 2022
|
Am I completely dumb, or am I missing something? Each time I restart my Dev, the Tracks I've created are gone. Otherwise the script work as intended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.