Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Qiskit Backends Implementation #52

Merged
merged 20 commits into from
Feb 10, 2021

Conversation

lazyoracle
Copy link
Member

@lazyoracle lazyoracle commented Feb 10, 2021

What

Under the hood improvements in C3-Qiskit integration

Why

Inheritance helps design more backends easily

How

  • Implemented an Abstract Base Class C3QasmSimulator to derive for qasm simulators in C3
  • Complete C3QasmPerfectSimulator for non-parametric gates
  • Pad gate names and generate gate-names string
  • Updated docs and examples with new qiskit interface
  • Minor fixes in c3.utils.qt_utils
  • Parametric gates implementation pending better naming scheme for parametric gates

@lazyoracle lazyoracle added this to the 1.2.2 milestone Feb 10, 2021
@lazyoracle lazyoracle self-assigned this Feb 10, 2021
@codecov-io
Copy link

codecov-io commented Feb 10, 2021

Codecov Report

Merging #52 (474bac6) into dev (dc99a0d) will decrease coverage by 0.26%.
The diff coverage is 65.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #52      +/-   ##
==========================================
- Coverage   47.44%   47.18%   -0.27%     
==========================================
  Files          35       35              
  Lines        4542     4593      +51     
==========================================
+ Hits         2155     2167      +12     
- Misses       2387     2426      +39     
Impacted Files Coverage Δ
c3/utils/qt_utils.py 40.17% <42.85%> (-2.14%) ⬇️
c3/qiskit/c3_backend.py 74.58% <64.75%> (-13.19%) ⬇️
c3/experiment.py 57.07% <75.00%> (-0.41%) ⬇️
c3/qiskit/c3_backend_utils.py 86.48% <85.00%> (+12.12%) ⬆️
c3/qiskit/c3_provider.py 85.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc99a0d...474bac6. Read the comment docs.

@lazyoracle lazyoracle added the enhancement New feature or request label Feb 10, 2021
@lazyoracle lazyoracle merged commit b29d319 into q-optimize:dev Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants