Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tunable coupler fixes #45

Merged
merged 7 commits into from
Feb 7, 2021
Merged

Tunable coupler fixes #45

merged 7 commits into from
Feb 7, 2021

Conversation

nwittler
Copy link
Collaborator

@nwittler nwittler commented Feb 6, 2021

  • Bug fixes and a CZ fidelity function for a tunable coupler.
  • Added projection for fidelities in larger Hilbert spaces.

@codecov-io
Copy link

Codecov Report

Merging #45 (6ac6ba0) into dev (50052a5) will decrease coverage by 0.29%.
The diff coverage is 13.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #45      +/-   ##
==========================================
- Coverage   46.92%   46.62%   -0.30%     
==========================================
  Files          35       35              
  Lines        4492     4525      +33     
==========================================
+ Hits         2108     2110       +2     
- Misses       2384     2415      +31     
Impacted Files Coverage Δ
c3/main.py 0.00% <0.00%> (ø)
c3/utils/log_reader.py 0.00% <0.00%> (ø)
c3/utils/parsers.py 0.00% <ø> (ø)
c3/utils/qt_utils.py 35.14% <11.11%> (-0.64%) ⬇️
c3/libraries/fidelities.py 18.50% <22.22%> (+0.21%) ⬆️
c3/experiment.py 55.44% <100.00%> (-0.38%) ⬇️
c3/optimizers/c2.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50052a5...6ac6ba0. Read the comment docs.

@lazyoracle
Copy link
Member

If this is required for the Chalmer's simulation, I guess we should just go ahead and merge this to dev asap even if there are still some rough edges?

@shaimach
Copy link
Collaborator

shaimach commented Feb 6, 2021 via email

@nwittler nwittler merged commit d52ce1a into dev Feb 7, 2021
@nwittler nwittler deleted the tunable_coupler_fixes branch February 7, 2021 14:56
@lazyoracle lazyoracle added this to the 1.2.2 milestone Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants