Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config hotfix #41

Merged
merged 9 commits into from
Feb 4, 2021
Merged

Config hotfix #41

merged 9 commits into from
Feb 4, 2021

Conversation

nwittler
Copy link
Collaborator

@nwittler nwittler commented Feb 4, 2021

Fixed some of the new classes that didn't play nice with config files.

@codecov-io
Copy link

codecov-io commented Feb 4, 2021

Codecov Report

Merging #41 (032fbb1) into dev (6147d84) will decrease coverage by 0.02%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #41      +/-   ##
==========================================
- Coverage   46.95%   46.92%   -0.03%     
==========================================
  Files          35       35              
  Lines        4453     4492      +39     
==========================================
+ Hits         2091     2108      +17     
- Misses       2362     2384      +22     
Impacted Files Coverage Δ
c3/experiment.py 55.82% <10.00%> (-2.34%) ⬇️
c3/libraries/envelopes.py 36.87% <19.60%> (-0.48%) ⬇️
c3/c3objs.py 79.56% <40.00%> (-2.46%) ⬇️
c3/system/chip.py 75.10% <83.33%> (+0.10%) ⬆️
c3/generator/devices.py 71.69% <100.00%> (+0.05%) ⬆️
c3/generator/generator.py 93.22% <100.00%> (+0.23%) ⬆️
c3/parametermap.py 91.97% <100.00%> (+0.10%) ⬆️
c3/signal/pulse.py 91.93% <100.00%> (ø)
c3/system/model.py 79.71% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6147d84...032fbb1. Read the comment docs.

@nwittler nwittler merged commit 50052a5 into dev Feb 4, 2021
@nwittler nwittler deleted the config_hotfix branch February 4, 2021 16:50
@lazyoracle lazyoracle added this to the 1.2.2 milestone Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants