Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qiskit serialise #128

Merged
merged 3 commits into from
Jul 8, 2021
Merged

Qiskit serialise #128

merged 3 commits into from
Jul 8, 2021

Conversation

lazyoracle
Copy link
Member

What

Allows for serialisation of results from c3.qiskit simulator

Why

Closes #127

How

  • Convert shots_data to python list after rounding the np.ndarray
  • Added regression tests to ensure results are always serialisable

Remarks

Add notes on possible known quirks/drawbacks of this solution. If this introduces an API-breaking change, please provide an explanation on why it is necessary to break API compatibility and how users should update their notebook/script workflows once this PR is merged.

Checklist

Please include and complete the following checklist. Your Pull Request is (in most cases) not ready for review until the following have been completed. You can create a draft PR while you are still completing the checklist. Check the Contribution Guidelines for more details. You can mark an item as complete with the - [x] prefix

  • Tests - Added unit tests for new code, regression tests for bugs and updated the integration tests if required
  • Formatting & Linting - black and flake8 have been used to ensure styling guidelines are met
  • Type Annotations - All new code has been type annotated in the function signatures using type hints
  • Docstrings - Docstrings have been provided for functions in the numpydoc style
  • Documentation - The tutorial style documentation has been updated to explain changes & new features
  • Notebooks - Example notebooks have been updated to incorporate changes and new features
  • Changelog - A short note on this PR has been added to the Upcoming Release section

@lazyoracle lazyoracle added the bug Something isn't working label Jul 8, 2021
@lazyoracle lazyoracle added this to the 1.3 milestone Jul 8, 2021
@lazyoracle lazyoracle requested a review from picbeats July 8, 2021 10:14
@lazyoracle lazyoracle self-assigned this Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #128 (3277fad) into dev (96dd10f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #128   +/-   ##
=======================================
  Coverage   67.51%   67.51%           
=======================================
  Files          36       36           
  Lines        5162     5162           
=======================================
  Hits         3485     3485           
  Misses       1677     1677           
Impacted Files Coverage Δ
c3/qiskit/c3_backend.py 78.91% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96dd10f...3277fad. Read the comment docs.

@lazyoracle lazyoracle merged commit 8dafe72 into q-optimize:dev Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

C3QasmPerfectSemulator output uses numpy types
2 participants