-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resurrect Model learning #117
Conversation
ae085d4
to
ce9e3b7
Compare
Blackbox freq 5e9 and anhar -210e6 Model freq: { value: 5000100000.0 min_val: 4995000000.0 max_val: 5005000000.0 unit: Hz 2pi symbol: \alpha } Model anhar: { value: -210001000.0 min_val: -380000000.0 max_val: -120000000.00000003 unit: Hz 2pi symbol: \alpha }
The dataset is an ORBIT experiment with 20 ORBIT sequences, and altogether 30 experiments (calibration runs) were performed. The blackbox is a 1 qubit device with freq 5e9 and anhar -210e6
Codecov Report
@@ Coverage Diff @@
## dev #117 +/- ##
==========================================
+ Coverage 58.82% 63.63% +4.81%
==========================================
Files 36 36
Lines 5326 5327 +1
==========================================
+ Hits 3133 3390 +257
+ Misses 2193 1937 -256
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The comment is optional. We might go over the example notebook and the docs in more detail after the merge.
m_shots = data_set["shots"][:seqs_pp] | ||
sequences = data_set["seqs"][:seqs_pp] | ||
with open(self.logdir + self.logname, "a") as logfile: | ||
logfile.write( | ||
f"\n Parameterset {ipar + 1}, #{count} of {len(indeces)}:\n" | ||
f"{str(self.exp.pmap)}\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing str(self.exp.pmap)
is correct, but do we instead want to print the current parameters in human-readable form here? exp.str_parameters()
should do the trick.
What
Fill missing gaps in Model Learning code, test, docs and examples
Why
Fixes #91
How
c3/optimizers/c3.py
test/c3.cfg
to be compatible with datasetc2_blackbox_exp.hjson
test/test_optim_init.py
for model learning optimization objects