Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the command to clean up docker images #2726

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

agunapal
Copy link
Collaborator

@agunapal agunapal commented Oct 19, 2023

Description

It seems like we were not cleaning up the older images in the regression run correctly.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Docker regression Run

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #2726 (1d6cf58) into master (551d2c7) will not change coverage.
The diff coverage is n/a.

❗ Current head 1d6cf58 differs from pull request most recent head 0096d57. Consider uploading reports for the commit 0096d57 to get more accurate results

@@           Coverage Diff           @@
##           master    #2726   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          85       85           
  Lines        3963     3963           
  Branches       58       58           
=======================================
  Hits         2871     2871           
  Misses       1088     1088           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@agunapal agunapal added this pull request to the merge queue Oct 19, 2023
Merged via the queue into master with commit ea87a48 Oct 19, 2023
13 checks passed
Copy link
Collaborator

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
edit: too late....

@agunapal agunapal deleted the issues/cleanup_docker_old_images branch October 19, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants