Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bash snippets in Docker.md #2345

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Fix bash snippets in Docker.md #2345

merged 4 commits into from
Aug 30, 2023

Conversation

dmitsf
Copy link
Contributor

@dmitsf dmitsf commented May 13, 2023

Description

Just fix the bash snippets in this file. The current ones are a bit broken due to incorrect indentation.

How that was before:

Screenshot 2023-05-13 at 12 06 40 PM

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

This is just a README-related change, don't require tests.

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Just fix the bash snippets in this file. The current ones are a bit broken due to incorrect indentation.
@dmitsf dmitsf changed the title Fix code snippets in Docker.md Fix bash snippets in Docker.md May 13, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #2345 (17dd4ef) into master (39e715d) will not change coverage.
The diff coverage is n/a.

❗ Current head 17dd4ef differs from pull request most recent head 990bcb4. Consider uploading reports for the commit 990bcb4 to get more accurate results

@@           Coverage Diff           @@
##           master    #2345   +/-   ##
=======================================
  Coverage   72.86%   72.86%           
=======================================
  Files          78       78           
  Lines        3697     3697           
  Branches       58       58           
=======================================
  Hits         2694     2694           
  Misses        999      999           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim added documentation Improvements or additions to documentation docker labels Aug 25, 2023
@msaroufim msaroufim added this pull request to the merge queue Aug 30, 2023
Merged via the queue into pytorch:master with commit 4a3c0e1 Aug 30, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants