Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugins/gradle.properties #1791

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Update plugins/gradle.properties #1791

merged 4 commits into from
Oct 21, 2022

Conversation

liyaodev
Copy link
Contributor

@liyaodev liyaodev commented Aug 12, 2022

Description

Fixes #1790

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

cd serve
plugins/gradlew -p plugins clean bS

> Task :DDBEndPoint:buildSagemaker
building DDBEndPoint
Copying files fromtask ':DDBEndPoint:jar' into /.../serve/plugins/build/plugins

> Task :endpoints:buildSagemaker
building endpoints
Copying files fromtask ':endpoints:jar' into /.../serve/plugins/build/plugins

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.4/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 6s
9 actionable tasks: 9 executed

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@liyaodev liyaodev changed the title Update gradle.properties Update plugins/gradle.properties Aug 12, 2022
@rohithkrn
Copy link
Collaborator

@liyaodev did it start failing recently?

@liyaodev
Copy link
Contributor Author

@rohithkrn I get an error when I build a plugins project alone

@liyaodev
Copy link
Contributor Author

@rohithkrn I get an error when I build a plugins project alone

Error logs

* Where:
Build file '/.../serve/plugins/DDBEndPoint/build.gradle' line: 13

* What went wrong:
A problem occurred evaluating project ':DDBEndPoint'.
>Could not get unknown property 'testng_version' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #1791 (cebbaa8) into master (9c6ef1d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1791   +/-   ##
=======================================
  Coverage   44.95%   44.95%           
=======================================
  Files          63       63           
  Lines        2609     2609           
  Branches       56       56           
=======================================
  Hits         1173     1173           
  Misses       1436     1436           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maaquib maaquib merged commit da6bb56 into pytorch:master Oct 21, 2022
@liyaodev liyaodev deleted the patch-1 branch October 24, 2022 03:27
jagadeeshi2i pushed a commit to jagadeeshi2i/serve that referenced this pull request Nov 1, 2022
Fix pytorch#1790

Co-authored-by: Aaqib <maaquib@gmail.com>
jagadeeshi2i pushed a commit to jagadeeshi2i/serve that referenced this pull request Nov 3, 2022
Fix pytorch#1790

Co-authored-by: Aaqib <maaquib@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in compiling plugins
4 participants