-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: volume permission in kubernetes setup #1747
Conversation
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Codecov Report
@@ Coverage Diff @@
## master #1747 +/- ##
==========================================
+ Coverage 41.67% 44.95% +3.28%
==========================================
Files 55 63 +8
Lines 2282 2609 +327
Branches 1 56 +55
==========================================
+ Hits 951 1173 +222
- Misses 1331 1436 +105
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagadeeshi2i Could you please clarify in the description how this is fixing 1337 Also could you please clarify what I am supposed to look at in the test.log. Could you please share the before/after log?
Hi @agunapal the securityContext fix is not required for native torchserve. As TS mount the PV in |
…erve into fix/pv-permission
* fix: volume permission in torchserve kubernetes Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com> * Trigger Build * Trigger Build Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com> Co-authored-by: Geeta Chauhan <4461127+chauhang@users.noreply.github.com> Co-authored-by: Aaqib <maaquib@gmail.com> Co-authored-by: Mark Saroufim <marksaroufim@fb.com>
* fix: volume permission in torchserve kubernetes Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com> * Trigger Build * Trigger Build Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com> Co-authored-by: Geeta Chauhan <4461127+chauhang@users.noreply.github.com> Co-authored-by: Aaqib <maaquib@gmail.com> Co-authored-by: Mark Saroufim <marksaroufim@fb.com>
Signed-off-by: jagadeesh jagadeeshj@ideas2it.com
Description
Fixes security context issue while installing TS helm chart. The model-server user own the
/home/model-server
path where the volume is being mounted.Fixes #1337
TS install output:
TS pod describe output:
test.log
Type of change
Please delete options that are not relevant.
Checklist: