-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HSTU ragged attention operator #2453
Open
xuzhao9
wants to merge
1
commit into
main
Choose a base branch
from
xz9/add-hstu-ragged
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhao9
had a problem deploying
to
docker-s3-upload
September 11, 2024 18:23
— with
GitHub Actions
Error
xuzhao9
temporarily deployed
to
docker-s3-upload
September 11, 2024 18:23
— with
GitHub Actions
Inactive
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xuzhao9
force-pushed
the
xz9/add-hstu-ragged
branch
from
September 12, 2024 16:40
01b97cc
to
5c33dec
Compare
xuzhao9
had a problem deploying
to
docker-s3-upload
September 12, 2024 16:40
— with
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
September 12, 2024 16:40
— with
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
September 12, 2024 16:43
— with
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
September 12, 2024 16:43
— with
GitHub Actions
Error
xuzhao9
force-pushed
the
xz9/add-hstu-ragged
branch
from
September 12, 2024 16:44
248bc3a
to
3366be2
Compare
xuzhao9
had a problem deploying
to
docker-s3-upload
September 12, 2024 16:44
— with
GitHub Actions
Error
xuzhao9
temporarily deployed
to
docker-s3-upload
September 12, 2024 16:44
— with
GitHub Actions
Inactive
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xuzhao9
had a problem deploying
to
docker-s3-upload
September 12, 2024 18:03
— with
GitHub Actions
Error
xuzhao9
temporarily deployed
to
docker-s3-upload
September 12, 2024 18:03
— with
GitHub Actions
Inactive
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: As the title says. On H100: ``` $ python run_benchmark.py triton --op ragged_attention x_val hstu_triton_ragged_attention-latency hstu_triton_ragged_attention_persistent-latency ----------------- -------------------------------------- ------------------------------------------------- (8, 4, 512, 2048) 0.0141706 0.0128713 (8, 4, 512, 2048) 0.0187315 0.0171204 (8, 4, 512, 2048) 0.0156807 0.0155399 (8, 4, 512, 2048) 0.0165724 0.0154679 (8, 4, 512, 2048) 0.0163886 0.0157738 (8, 4, 512, 2048) 0.0173378 0.0155991 (8, 4, 512, 2048) 0.0164874 0.0153128 (8, 4, 512, 2048) 0.0203275 0.0172193 (8, 4, 512, 2048) 0.0214526 0.0185414 (8, 4, 512, 2048) 0.0172307 0.0169625 ``` Differential Revision: D62513596 Pulled By: xuzhao9
facebook-github-bot
force-pushed
the
xz9/add-hstu-ragged
branch
from
September 12, 2024 19:53
48cb738
to
0ae15fa
Compare
This pull request was exported from Phabricator. Differential Revision: D62513596 |
facebook-github-bot
had a problem deploying
to
docker-s3-upload
September 12, 2024 19:53
— with
GitHub Actions
Failure
facebook-github-bot
temporarily deployed
to
docker-s3-upload
September 12, 2024 19:53
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says.
On H100: