Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inference_mode #885

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

jerryzh168
Copy link
Contributor

Summary:
Fixes: #875

Test Plan:
Test locally with tutorials/quantize_vit/run_vit_b_quant.py with:

with torch.inference_mode():
    benchmark_model(model, 20, inputs)

but can't repro the issue in unit tests

Reviewers:

Subscribers:

Tasks:

Tags:

Summary:
Fixes: pytorch#875

Test Plan:
Test locally with tutorials/quantize_vit/run_vit_b_quant.py
with:
```
with torch.inference_mode():
    benchmark_model(model, 20, inputs)
```

but can't repro the issue in unit tests

Reviewers:

Subscribers:

Tasks:

Tags:
Copy link

pytorch-bot bot commented Sep 13, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/885

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7b412e3 with merge base 16b40fd (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2024
Copy link
Contributor

@jcaip jcaip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jerryzh168 jerryzh168 merged commit 90c8cbd into pytorch:main Sep 13, 2024
17 checks passed
@jerryzh168 jerryzh168 deleted the linear-inference-mode branch September 13, 2024 23:19
Copy link

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jainapurva pushed a commit that referenced this pull request Sep 22, 2024
Summary:
Fixes: #875

Test Plan:
Test locally with tutorials/quantize_vit/run_vit_b_quant.py
with:
```
with torch.inference_mode():
    benchmark_model(model, 20, inputs)
```

but can't repro the issue in unit tests

Reviewers:

Subscribers:

Tasks:

Tags:
jainapurva pushed a commit that referenced this pull request Sep 23, 2024
Summary:
Fixes: #875

Test Plan:
Test locally with tutorials/quantize_vit/run_vit_b_quant.py
with:
```
with torch.inference_mode():
    benchmark_model(model, 20, inputs)
```

but can't repro the issue in unit tests

Reviewers:

Subscribers:

Tasks:

Tags:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AffineQuantizedTensor dispatch: attempting to run unimplemented operator/function: aten.linear.default
4 participants