Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bug in vgg16_fp8_ptq example #2950

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Conversation

zewenli98
Copy link
Collaborator

Description

Fix a bug in vgg16_fp8_ptq.py example.

Fixes #2932

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 requested a review from peri044 June 24, 2024 22:52
@zewenli98 zewenli98 changed the title fix: bug in vgg16_fp8_ptq example [WIP] fix: bug in vgg16_fp8_ptq example Jun 24, 2024
@zewenli98 zewenli98 changed the title [WIP] fix: bug in vgg16_fp8_ptq example fix: bug in vgg16_fp8_ptq example Jun 24, 2024
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change. LGTM

examples/dynamo/vgg16_fp8_ptq.py Outdated Show resolved Hide resolved
@zewenli98 zewenli98 merged commit f909b07 into main Jun 24, 2024
9 checks passed
@zewenli98 zewenli98 deleted the fix_bug_in_vgg16_fp8_ptq_example branch June 24, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should "model" be "trt_model" here?
3 participants