Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: dynamic shape support for rsqrt/erf ops #2929

Merged
merged 2 commits into from
Jun 24, 2024
Merged

chore: dynamic shape support for rsqrt/erf ops #2929

merged 2 commits into from
Jun 24, 2024

Conversation

keehyuna
Copy link
Collaborator

Description

dynamic shape support for rsqrt/erf ops

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Jun 17, 2024
@github-actions github-actions bot requested a review from apbose June 17, 2024 14:20
@keehyuna keehyuna requested a review from peri044 June 17, 2024 14:20
peri044
peri044 reviewed Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. minor change

tests/py/dynamo/conversion/test_rsqrt_aten.py Show resolved Hide resolved
@github-actions github-actions bot added the component: converters Issues re: Specific op converters label Jun 18, 2024
@keehyuna keehyuna self-assigned this Jun 18, 2024
@peri044 peri044 merged commit 7b825f5 into pytorch:main Jun 24, 2024
55 of 61 checks passed
@keehyuna keehyuna deleted the rsqrt_dynamic_shape branch August 19, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 left review comments

@apbose apbose Awaiting requested review from apbose

Assignees

@keehyuna keehyuna

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keehyuna @peri044 @facebook-github-bot