Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel in-progress ci build when a new commit is pushed #2903

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

lanluo-nvidia
Copy link
Collaborator

Description

Cancel the in-progress ci build when a new commit is pushed

Fixes # (issue)
too many ci/cd is running in parallel and wasted lots of runner resources

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review June 9, 2024 18:04
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment on concurrency restrictions. Additionally, consider changing the concurrency in windows-test.yml and linux-test.yml to match.

.github/workflows/build-test-linux.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@lanluo-nvidia lanluo-nvidia merged commit b32dc28 into main Jun 11, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants