Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dynamic shapes support for sqrt and copy #2889

Merged
merged 1 commit into from
Jun 7, 2024
Merged

feat: dynamic shapes support for sqrt and copy #2889

merged 1 commit into from
Jun 7, 2024

Conversation

chohk88
Copy link
Collaborator

@chohk88 chohk88 commented Jun 5, 2024 •
edited
Loading

Description

Add dynamic shape support for aten sqrt and copy operation

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@chohk88 chohk88 added the component: converters Issues re: Specific op converters label Jun 5, 2024
@chohk88 chohk88 self-assigned this Jun 5, 2024
@github-actions github-actions bot requested a review from zewenli98 June 5, 2024 15:39
@github-actions github-actions bot added component: tests Issues re: Tests component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths and removed component: converters Issues re: Specific op converters labels Jun 5, 2024
@github-actions github-actions bot requested a review from narendasan June 5, 2024 15:39
peri044
peri044 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit 8b43f4b into main Jun 7, 2024
46 of 61 checks passed
@narendasan narendasan deleted the dynamic_shapes_sqrt_copy branch June 7, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peri044 peri044 peri044 approved these changes

@apbose apbose Awaiting requested review from apbose

@keehyuna keehyuna Awaiting requested review from keehyuna

@lanluo-nvidia lanluo-nvidia Awaiting requested review from lanluo-nvidia

@zewenli98 zewenli98 Awaiting requested review from zewenli98

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@chohk88 chohk88

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chohk88 @peri044 @narendasan @facebook-github-bot