Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support cumsum dynamo converter #2403

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

zewenli98
Copy link
Collaborator

Description

Support cumsum dynamo converter. This is a part of slice converter.

Fixes part of #2215

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 self-assigned this Oct 18, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests labels Oct 18, 2023
Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comments, otherwise looks good!

py/torch_tensorrt/dynamo/conversion/impl/slice/ops.py Outdated Show resolved Hide resolved
py/torch_tensorrt/dynamo/conversion/impl/slice/ops.py Outdated Show resolved Hide resolved
@zewenli98
Copy link
Collaborator Author

Thanks for the comments! They have been fixed!

Copy link
Collaborator

@gs-olive gs-olive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Please rebase once #2418 is merged, and then ensure this PR also passes all of CI.

@zewenli98
Copy link
Collaborator Author

Got errors:

FAILED models/test_export_serde.py::test_base_full_compile - TypeError: __init__() got an unexpected keyword argument 'parameters'
FAILED models/test_export_serde.py::test_base_full_compile_multiple_outputs - TypeError: __init__() got an unexpected keyword argument 'parameters'
FAILED models/test_export_serde.py::test_base_full_compile_save_load - TypeError: __init__() got an unexpected keyword argument 'parameters'
FAILED models/test_export_serde.py::test_hybrid_relu_fallback - TypeError: __init__() got an unexpected keyword argument 'parameters'
FAILED models/test_export_serde.py::test_resnet18_save_load - KeyError: 'parameter name can\'t contain "."'

Can we merge it now? or waiting for a fix to this bug?

@gs-olive
Copy link
Collaborator

I think it can be merged while that fix is in progress, since it passes all of the newly added tests in CI and none of those models would invoke this specific converter.

@zewenli98 zewenli98 merged commit f617898 into pytorch:main Oct 31, 2023
15 of 19 checks passed
gs-olive pushed a commit that referenced this pull request Dec 5, 2023
gs-olive pushed a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants