Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add decomposition for aten.addmm #1953

Merged
merged 1 commit into from
May 30, 2023
Merged

fix: Add decomposition for aten.addmm #1953

merged 1 commit into from
May 30, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented May 25, 2023 •
edited
Loading

Description

  • Decompose addmm operator into mul, matmul, and add ops
  • Add test case for addmm decomposition

Fixes #1790

Type of change

  • Improved operator coverage

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this May 25, 2023
@gs-olive gs-olive added component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths and removed cla signed labels May 25, 2023
@github-actions github-actions bot added the component: api [Python] Issues re: Python API label May 25, 2023
@github-actions github-actions bot requested a review from narendasan May 25, 2023 16:54
@gs-olive gs-olive force-pushed the addmm_dynamo_lowering_pass branch from f915fb3 to 9fa7f44 Compare May 25, 2023 17:55
@gs-olive gs-olive requested a review from apbose May 25, 2023 18:09
@gs-olive gs-olive force-pushed the addmm_dynamo_lowering_pass branch from 9fa7f44 to e101d36 Compare May 25, 2023 18:54
@gs-olive gs-olive marked this pull request as ready for review May 25, 2023 18:54
@gs-olive
fix: Add decomposition for aten.addmm
92a207b 
- Decompose addmm operator into mul, matmul, and add ops
- Add test case for addmm decomposition
@gs-olive gs-olive force-pushed the addmm_dynamo_lowering_pass branch from e101d36 to 92a207b Compare May 26, 2023 17:05
narendasan
narendasan approved these changes May 30, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit f65340d into pytorch:main May 30, 2023
@gs-olive gs-olive deleted the addmm_dynamo_lowering_pass branch May 30, 2023 23:49
narendasan pushed a commit that referenced this pull request Jun 2, 2023
@gs-olive @narendasan
fix: Add decomposition for aten.addmm (#1953)
7c7cbdd
narendasan pushed a commit that referenced this pull request Jun 2, 2023
@gs-olive @narendasan
fix: Add decomposition for aten.addmm (#1953)
346e9f7
narendasan pushed a commit that referenced this pull request Jun 3, 2023
@gs-olive @narendasan
fix: Add decomposition for aten.addmm (#1953)
6cd7b8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@apbose apbose apbose approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨[Converter] Implement aten::addmm
4 participants
@gs-olive @narendasan @apbose @facebook-github-bot