Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Error caused by invalid binding name in TRTEngine.to_str() method #1846

Merged
merged 1 commit into from
Apr 20, 2023
Merged

fix: Error caused by invalid binding name in TRTEngine.to_str() method #1846

merged 1 commit into from
Apr 20, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Apr 20, 2023 •
edited
Loading

Description

  • Fix to_str() method using invalid binding names for TRT Engines
  • Method was using standard I/O names of the form input_*, output_*, which does not represent the full range of potential names
  • Update implementation to access binding names directly from binding names array
  • Update debug message printing to improve readability + clarity + provided information

Fixes #1844

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
fix: Error caused by invalid binding name
e1abcbb 
- Fix `to_str()` method using invalid binding names for TRT Engines
- Method was using standard I/O names of the form `input_*`, `output_*`,
which does not represent the full range of potential names
- Update implementation to access binding names directly from binding
names array
- Update debug message printing to improve readability + clarity
@gs-olive gs-olive self-assigned this Apr 20, 2023
@gs-olive gs-olive marked this pull request as ready for review April 20, 2023 18:40
@github-actions github-actions bot added component: core Issues re: The core compiler component: runtime labels Apr 20, 2023
narendasan
narendasan approved these changes Apr 20, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit 5f77f56 into pytorch:main Apr 20, 2023
bowang007 pushed a commit that referenced this pull request Apr 28, 2023
@gs-olive @bowang007
fix: Error caused by invalid binding name in TRTEngine.to_str() met…
47df4cd 
…hod (#1846)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed component: core Issues re: The core compiler component: runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

❓ [Question] Internal Error-given invalid tensor name
3 participants
@gs-olive @narendasan @facebook-github-bot