Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Repair invalid schema arising from lowering pass #1786

Merged
merged 1 commit into from
Mar 30, 2023

Commits on Mar 30, 2023

  1. fix: Repair invalid schema arising from lowering pass

    - When `remove_unnecessary_casts` replaces both tensors in an
    `aten::div` call with the corresponding scalars, and the rounding mode
    (third argument) is specified, the schema becomes invalid
    - To avoid this, we intercept the call and split the result based on
    what the third argument in the input was, either delegating the result
    to `aten::Int(aten::div(...))`, for "trunc" or `aten::floordiv(...)` for
    "floor"
    - Update lowering pass to incorporate the above change, with appropriate
    documentation
    - Add testing to verify catching and correctly handling these edge cases
    gs-olive committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    3db9670 View commit details
    Browse the repository at this point in the history