Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on unpacking self in NamedTuple #17351

Merged
merged 2 commits into from
Jun 9, 2024
Merged

Fix crash on unpacking self in NamedTuple #17351

merged 2 commits into from
Jun 9, 2024

Conversation

ilevkivskyi
Copy link
Member

Fixes #17010

Fix is trivial: replicate the TypeVar handling logic in the caller.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2024

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@ilevkivskyi ilevkivskyi merged commit 09e6a2b into python:master Jun 9, 2024
18 checks passed
@ilevkivskyi ilevkivskyi deleted the fix-unpack-self branch June 9, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ilevkivskyi @AlexWaygood