Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stubtest: special case final and deprecated #16457

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

hauntsaninja
Copy link
Collaborator

We should probably lean into the type checker harder here

Fixes #14950
Fixes python/typeshed#11009 (comment)

We should probably lean into the type checker harder here

Fixes python#14950
Fixes python/typeshed#11009 (comment)
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@ilevkivskyi ilevkivskyi merged commit 8ae84ed into python:master Nov 11, 2023
18 checks passed
@hauntsaninja hauntsaninja deleted the stubtest-dec branch November 11, 2023 20:22
@@ -119,6 +119,9 @@
# Supported Annotated type names.
ANNOTATED_TYPE_NAMES: Final = ("typing.Annotated", "typing_extensions.Annotated")

# Supported @deprecated type names
DEPRECATED_TYPE_NAMES: Final = ("typing.deprecated", "typing_extensions.deprecated")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be warnings.deprecated, I'll send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stubtest crashes on a stub with an overloaded method where the first overload is decorated with @final
3 participants