Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on joins with recursive tuples #15402

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

ilevkivskyi
Copy link
Member

Fixes #15351

This may have some perf impact, but I predict it will be minimal (and I didn't notice anything locally).

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I don't expect this to have significant perf impact.

@JukkaL JukkaL merged commit 3e982a0 into python:master Jun 9, 2023
@ilevkivskyi ilevkivskyi deleted the fix-rec-crash-2 branch June 9, 2023 15:39
jhance pushed a commit that referenced this pull request Jun 12, 2023
Fixes #15351

This may have some perf impact, but I predict it will be minimal (and I
didn't notice anything locally).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault/RecursionError when using tuple, one item literal and self-referencing type
2 participants