Do not block on duplicate base classes #15367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
test-data/unit/check-classes.test
Outdated
| ... | ||
|
|
||
| b: B | ||
| # We use dummy type info, so no real attrs will be there: |
There was a problem hiding this comment.
That's pretty unfortunate, can we make it inherit from Any or just skip the duplicate base instead?
This comment has been minimized.
This comment has been minimized.
hauntsaninja
reviewed
Jun 4, 2023
|
@hauntsaninja I don't fill comfortable doing this. Because we can have two generic bases: |
|
Okay! I went ahead and added a test case for that situation |
|
Diff from mypy_primer, showing the effect of this PR on open source code: vision (https://github.com/pytorch/vision) got 1.36x slower (40.8s -> 55.5s)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JelleZijlstra I don't really have a prefence on this issue. I am fine with both blocking and non-blocking errors here.
But, it looks like that making this non-blocking is quite straight-forward.
Closes #15349