Add documentation for bytes formatting error code #14971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/source/error_code_list.rst
Outdated
| Check that function isn't used in boolean context [str-bytes-safe] | ||
| ------------------------------------------------------------------- | ||
|
|
||
| Warn about dangerous coercions related to bytes and string types. |
There was a problem hiding this comment.
Not sure "dangerous" is the right word since it won't crash, just give potentially unexpected output.
There was a problem hiding this comment.
I feel like the theme here is "implicit" which makes the intention ambiguous.
There was a problem hiding this comment.
Agree, "implicit" is a good word to use
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
ethanhs
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #14959