Add Error format support, and JSON output option #11396
Conversation
mypy/error_formatter.py
Outdated
| return json.dumps({ | ||
| 'file': file, | ||
| 'line': line, | ||
| 'column': column, |
There was a problem hiding this comment.
line, column seems short-sighed.
Maybe startLine, startColumn, which would leave room to later add endLine, endColumn. This information is useful for IDEs to know how what span to highlight.
There was a problem hiding this comment.
Yeah, good point.
But mypy currently only does line and column, and it might be very long before spans are added in. It could be argued that the change to startLine and startColumn can be made when the feature exists.
There was a problem hiding this comment.
Changing the field names later will break tools though. And startLine, startColumn would already be accurate right now, because mypy currently points out the start of the span.
There was a problem hiding this comment.
I'll leave this convention for the separate --output=sarif format.
|
I'd like to make the case again for the existing JSON-based standard: Static Analysis Results Interchange Format (SARIF) While that does not preclude support for a custom JSON format as well, perhaps if mypy were to support SARIF, there would be no need for a custom format? Pros of SARIF:
Cons:
[1] The plugin ratings are 3.4 and 2.9 out of 5 😖 https://plugins.jetbrains.com/search?search=mypy Example minimal mypy SARIF output{
"version": "2.1.0",
"$schema": "https://schemastore.azurewebsites.net/schemas/json/sarif-2.1.0.json",
"runs": [
{
"tool": {
"driver": {
"name": "mypy",
"version": "0.910"
}
},
"results": [
{
"ruleId": "assignment",
"level": "error",
"message": {
"text": "Incompatible types in assignment (expression has type \"str\", variable has type \"int\")"
},
"locations": [
{
"physicalLocation": {
"artifactLocation": {
"uri": "mytest.py"
},
"region": {
"startLine": 2,
"startColumn": 4
}
}
}
]
},
{
"ruleId": "name-defined",
"level": "error",
"message": {
"text": "Name \"z\" is not defined"
},
"locations": [
{
"physicalLocation": {
"artifactLocation": {
"uri": "mytest.py"
},
"region": {
"startLine": 3,
"startColumn": 4
}
}
}
]
}
]
}
]
} |
|
+1 for SARIF format, let's use a common format instead of a mypy custom one ! :) |
|
I'm willing to turn it into SARIF (basing it on the json snippet provided by @intgr), if that's what I need to get this into mypy 😄 @ethanhs @TH3CHARLie what do you think? |
|
After sitting on it a little, I feel that there's room for more than one machine-readable format. The simpler json-line-based format is probably better for simple tools that only care about mypy. I'm willing to implement the SARIF part myself. But I shouldn't be the one to decide that, I'm just an occasional lurker here. No mypy developers have chipped in yet. |
|
I'm just a tourist here, but i'm currently activating SARIF output for all linters of MegaLinter, and having native SARIF output is a great benefit for linters ^^ ( + the Github CodeQL that natively understands SARIF format ^^ ) Some other python linters already have SARIF output, like bandit , maybe there is some code to reuse to manage the format ? |
|
@nvuillam this PR introduces an ErrorFormatter class. By the time this PR is finalized, even if it doesn't use SARIF you will be able to define your own ErrorFormatter class in a plugin probably, and tell it to output the SARIF format, it'll be really easy. Pylint has the same setup. |
|
@tusharsadhwani thank but... I don't have the bandwidth to implement SARIF output on all linters that do not manage it yet 😅 |
|
I think one property that machine-readable formats should have is: if one error causes multiple lines of output, then that should appear as one result item rather than multiple. So for example with should maybe be output as {
"file": "_local/multi_error.py",
"line": 5,
"column": 8,
"severity": "error",
"context": "In function \"foo\":",
"message": "No overload variant of \"get\" of \"Mapping\" matches argument type \"str\"",
"hint": "Possible overload variants:\n def get(self, key: Any) -> Any\n def [_T] get(self, key: Any, default: Union[Any, _T]) -> Union[Any, _T]",
"code": "call-overload"
}But again, maybe that shouldn't be a blocker for this PR, getting machine-readable output can be useful even when findings aren't accurately grouped. The negative line/column numbers right now seem awkward though: {"file": "_local/multi_error.py", "line": -1, "column": -1, "severity": "note", "message": "In function \"foo\":", "code": null} |
|
That's definitely a bug. The mypy code that generates this output was ridiculously coupled. I'll take a look at if this can be fixed. |
|
It has been many months as the project has hoped for a best solution over an existing solution. Can we merge this and accept future improvement using |
|
@intgr I did it properly this time. Hints should be fixed now. |
|
|
|
@sehyun-hwang sure thing. If you could provide a reproducible example I can look into it right away. |
|
@tusharsadhwani Thank you! I tried linting jobs in a container, and was unable to reproduce it. The problem occurs only when my IDE invokes dmypy, so I'm suspecting this has to do with concurrent execution. Do you see a chance where |
|
I found that the first file linted output a json format, but from the second one it goes back to the string format. Can you try to reproduce this? |
|
@sehyun-hwang This seems like a dmypy bug. It seems that dmypy ignores cli flags or config file flags in certain cases. Here's a file structure: $ tree .
.
├── a.py
├── b.py
└── mypy.iniAnd [mypy]
strict = True
def foo(): passThis way |
|
@intgr Could you take a look at the comment by @tusharsadhwani ? |
|
I'm afraid I can't help much with this. Just to clarify, I think my name shows up in the "reviewers" list only because I left a code comment about this PR earlier. I'm not a maintainer or reviewer in an official capacity and I don't have much knowledge of mypy's internals. I'm just a user interested in consuming structured output from mypy (and potentially adding SARIF support later on). That's why I shared my opinions in this comment thread. |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
@JelleZijlstra CI is taken care of. |
|
I'm not sure we'd accept support for other output formats in mypy itself, since we'd take on additional maintenance load. If this PR is merged, such formats could be supported in external tools that consume mypy's JSON output. |
Thanks, I'll take a look soon. |
|
Yeah, the scope of this project has nothing to do with integrating various git servers' CI runners. That would be a rabbit hole of tech debt. |
mypy/errors.py
Outdated
| # No error tuple found for this hint. Ignoring it | ||
| continue | ||
|
|
||
| if error.hint == "": |
There was a problem hiding this comment.
Could we make hint into a list of strings instead?
There was a problem hiding this comment.
It's often that a single hint is wrapped into multiple lines. For internal representaiton we can keep it as a list of strings but for the user I think it makes most sense to display it as a single string.
mypy/errors.py
Outdated
| error_location = (file_path, line, column) | ||
| error = latest_error_at_location.get(error_location) | ||
| if error is None: | ||
| # No error tuple found for this hint. Ignoring it |
There was a problem hiding this comment.
Why not instead generate a MypyError with some field that lets us indicate that this is a note?
mypy/options.py
Outdated
| self.force_uppercase_builtins = False | ||
| self.force_union_syntax = False | ||
|
|
||
| # Sets custom output format | ||
| self.output = "" |
There was a problem hiding this comment.
Would None be a better default?
| foo('42') | ||
|
|
||
| def bar() -> None: ... | ||
| bar('42') |
There was a problem hiding this comment.
Add a test case with reveal_type(); let's make sure that shows up in the output.
If mypy will only support 1 machine-parsable output format, then please choose a standard or de facto recognized format. Don't create yet another tool-specific mypy output format that everybody then has to write another set of adapters for. For example, tools already exist to convert SARIF into GitLab "CodeQuality" reports https://gitlab.com/ahogen/sarif-to-codequality. |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
FWIW I prefer current output as it is leaner and it's trivial for any tool to translate it to SARIF (pyright rejected the idea of adding SARIF for the same reason). But I will add a SARIF formatter in the same PR if maintainers agree to it. |
test-data/unit/outputjson.test
Outdated
| foo('42') | ||
|
|
||
| def bar() -> None: ... | ||
| bar('42') | ||
| [out] | ||
| {"file": "main", "line": 12, "column": 0, "message": "No overload variant of \"foo\" matches argument type \"str\"", "hint": "Possible overload variants:\n def foo() -> None\n def foo(x: int) -> None", "code": "call-overload"} | ||
| {"file": "main", "line": 15, "column": 0, "message": "Too many arguments for \"bar\"", "hint": null, "code": "call-arg"} | ||
| {"file": "main", "line": 12, "column": 12, "message": "Revealed type is \"Overload(def (), def (x: builtins.int))\"", "hint": null, "code": "misc", "is_note": true} |
There was a problem hiding this comment.
Could we change this to "severity": "note", mirroring mypy's Python code (and severity error for the errors)? That will also make it easier to extend to other kinds of severity in the future.
which I just commented.
Otherwise it will require yet another converter-to-sarif tool. There is plenty of support already in IDEs, linters aggregators, and other analysis tools. If you think that SARIF could be leaner, then I do propose you to participate in its committee (I'm not being cinic, I mean it, you may have a good idea), make your proposal, and discuss it. That would be the right approach so the whole static analysis community gets benefited. |
|
If I merge this PR, I take on the responsibility (at least in my mind) for triaging and reviewing future fixes to this area. I'm OK with doing that for this simple JSON format; I'm not OK with having to maintain compliance with the external SARIF spec. If another maintainer wants to add SARIF support, I'd welcome it, since clearly it will help some users, but I'm not interested in taking ownership of it. |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
I think this is close to ready. We'll also want to document the JSON format in the mypy documentation, but that can wait for a separate PR. |
|
@dgutson Thanks for bringing this PR to my attention again :)
I just made and verified a scipt to run mypy with SARIF output, dropping it here incase it is useful to someone: https://gist.github.com/tusharsadhwani/5fd7a3c32d73f10fcb86e8deac4b60cf |
could you please add it to the source tree? Otherwise it will be lost in a PR comment :) |
|
I think Jelle has made his stance clear. I'd rather not have this feature delayed potentially a few more months over that. Although I don't mind SARIF support, I'm not particularly looking for it, and neither are the maintainers super stoked about it yet, it seems. At this moment I think it'd be best to make a different issue for SARIF support. Feel free to use the gist as a basis for the PR against that issue. |
|
@JelleZijlstra sorry for always being that person, but is this released? Was just working on some automated tests for Strawberry and having JSON output would be make it much easier (we use that for pyright as well) |
not yet released, but you can track the progress of the next release in #17285. It should include this PR. |
Description
Resolves #10816
The changes this PR makes are relatively small.
It currently:
--outputoption to mypy CLIErrorFormatterabstract base class, which can be subclassed to create new output formatsMypyErrorclass that represents the external format of a mypy error.--outputbeing'json', in which case theJSONFormatteris used to produce the reported output.Demo:
A few notes regarding the changes:
ErrorTuples created during error reporting, instead of using the more generalErrorInfoclass, because a lot of machinery already exists in mypy for sorting and removing duplicate error reports, which producesErrorTuples at the end. The error sorting and duplicate removal logic could perhaps be separated out from the rest of the code, to be able to useErrorInfoobjects more freely.ErrorFormatterdoesn't really need to be an abstract class, but I think it would be better this way. If there's a different method that would be preferred, I'd be happy to know.--outputCLI option is, most probably, not added in the correct place. Any help in how to do it properly would be appreciated, the mypy option parsing code seems very complex.ErrorFormatterclass inside a mypy plugin, and adding anamefield to the formatters. The mypy runtime can then check through the__subclasses__of the formatter and determine if such a formatter is present.The "checking for the
namefield" part of this code might be appropriate to add within this PR itself, instead of hard-codingJSONFormatter. Does that sound like a good idea?