Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.660 planning #6130

Closed
msullivan opened this issue Jan 2, 2019 · 12 comments
Closed

Release 0.660 planning #6130

msullivan opened this issue Jan 2, 2019 · 12 comments

Comments

@msullivan
Copy link
Collaborator

I'd like to release mypy 0.660 on Friday, January 11. I plan to cut the release branch on Monday, January 7.

I plan to also release our first official mypy_mypyc binary alongside it.

If there are any PRs that need to make it in for the release, please mention them here.

@Michael0x2a
Copy link
Collaborator

Michael0x2a commented Jan 3, 2019

I have a host of Literal-types related PRs I'd like to get in if possible:

I also have two lower-priority PRs I'd like to get merged in: the first is cosmetic, and the second is just documentation and doesn't necessarily need to make the cutoff.

@JukkaL
Copy link
Collaborator

JukkaL commented Jan 4, 2019

If we ship a compiled binary by default, maybe the version should be incremented to 0.700. This is a major change, even if it doesn't bring any new functionality.

I might also want to make --fast-exit enabled by default.

@msullivan
Copy link
Collaborator Author

I hadn't been planning to make the compiled binary the default in this release yet, just to release and publicize an alternate compiled package.

@ethanhs
Copy link
Collaborator

ethanhs commented Jan 6, 2019

I would like to get #6148 in if possible. This should bring the daemon on Windows to feature parity with Unix.

@ethanhs
Copy link
Collaborator

ethanhs commented Jan 7, 2019

It would also be nice to get #6153 in since it fixes a rather confusing crash with the daemon.

@JukkaL
Copy link
Collaborator

JukkaL commented Jan 7, 2019

I hadn't been planning to make the compiled binary the default in this release yet, just to release and publicize an alternate compiled package.

Ok, 0.660 is good then and we don't need any --fast-exit changes.

@msullivan
Copy link
Collaborator Author

I am postponing the release to Wednesday, Jan 16. I'll cut the release branch later this week.

@Michael0x2a
Copy link
Collaborator

I have one final Literal-related PR I'd like to get in if possible. It should be a short one though: #6176

@msullivan
Copy link
Collaborator Author

I've cut the release branch

@msullivan
Copy link
Collaborator Author

We realized that it was a mistake to release typed_ast 1.1.1 with a breaking API change. As a result we are going to release a 1.2.0 and pull version 1.1.1, which means we need to get that out and update our dependency in mypy for this release.

msullivan added a commit that referenced this issue Jan 14, 2019
This should be cherry picked into the release branch (#6130)
msullivan added a commit that referenced this issue Jan 15, 2019
This should be cherry picked into the release branch (#6130)
@msullivan
Copy link
Collaborator Author

I'm cherry-picking #6191 because it is super low risk and might help reduce confusion of packagers?

msullivan added a commit that referenced this issue Jan 15, 2019
This should be cherry picked into the release branch (#6130)
@msullivan
Copy link
Collaborator Author

Release done! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants