Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.9] gh-101981: Build macOS as recommended by the devguide (GH-102070) #102186

Closed

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Feb 23, 2023

Automerge-Triggered-By: GH:erlend-aasland.
(cherry picked from commit 2713631)

…thonGH-102070)

Automerge-Triggered-By: GH:erlend-aasland.
(cherry picked from commit 2713631)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@ned-deily
Copy link
Member

I was mystified why this change now seems to work for 3.9 after the lengthy testing and discussion here shows that it shouldn't. But further investigation shows that, just 3 days ago, Homebrew made a change to their tcl-tk formula so that their Tcl/Tk is no longer "keg-only", meaning it is now linked into their normal install locations and, thus, the non-functional (as explained in the link) PKG_CONFIG_PATH addition is no longer needed with this latest Homebrew update! Great timing. We should re-examine the devguide directions and this change in that light. I'll think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants