Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Few coverage nitpicks for the cmath module #102067

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Few coverage nitpicks for the cmath module #102067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e368127
Few coverage nitpicks for the cmath module
skirpichev Feb 20, 2023
b54488e
Merge branch 'main' into cmath-cov
skirpichev Feb 20, 2023
1387cc2
Fix testcase to use correct rounding
mdickinson Feb 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Lib/test/cmath_testcases.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1536,6 +1536,7 @@ sqrt0141 sqrt -1.797e+308 -9.9999999999999999e+306 -> 3.7284476432057307e+152 -1
sqrt0150 sqrt 1.7976931348623157e+308 0.0 -> 1.3407807929942596355e+154 0.0
sqrt0151 sqrt 2.2250738585072014e-308 0.0 -> 1.4916681462400413487e-154 0.0
sqrt0152 sqrt 5e-324 0.0 -> 2.2227587494850774834e-162 0.0
sqrt0153 sqrt 5e-324 1.0 -> 0.7071067811865476 0.7071067811865476

-- special values
sqrt1000 sqrt 0.0 0.0 -> 0.0 0.0
Expand Down Expand Up @@ -1744,6 +1745,7 @@ cosh0023 cosh 2.218885944363501 2.0015727395883687 -> -1.94294321081968 4.129026
-- large real part
cosh0030 cosh 710.5 2.3519999999999999 -> -1.2967465239355998e+308 1.3076707908857333e+308
cosh0031 cosh -710.5 0.69999999999999996 -> 1.4085466381392499e+308 -1.1864024666450239e+308
cosh0032 cosh 720.0 0.0 -> inf 0.0 overflow

-- Additional real values (mpmath)
cosh0050 cosh 1e-150 0.0 -> 1.0 0.0
Expand Down Expand Up @@ -1853,6 +1855,7 @@ sinh0023 sinh 0.043713693678420068 0.22512549887532657 -> 0.042624198673416713 0
-- large real part
sinh0030 sinh 710.5 -2.3999999999999999 -> -1.3579970564885919e+308 -1.24394470907798e+308
sinh0031 sinh -710.5 0.80000000000000004 -> -1.2830671601735164e+308 1.3210954193997678e+308
sinh0032 sinh 720.0 0.0 -> inf 0.0 overflow

-- Additional real values (mpmath)
sinh0050 sinh 1e-100 0.0 -> 1.00000000000000002e-100 0.0
Expand Down
8 changes: 8 additions & 0 deletions Lib/test/test_cmath.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,14 @@ def test_complex_near_zero(self):
self.assertIsClose(0.001-0.001j, 0.001+0.001j, abs_tol=2e-03)
self.assertIsNotClose(0.001-0.001j, 0.001+0.001j, abs_tol=1e-03)

def test_complex_special(self):
self.assertIsNotClose(INF, INF*1j)
self.assertIsNotClose(INF*1j, INF)
self.assertIsNotClose(INF, -INF)
self.assertIsNotClose(-INF, INF)
self.assertIsNotClose(0, INF)
self.assertIsNotClose(0, INF*1j)


if __name__ == "__main__":
unittest.main()
4 changes: 2 additions & 2 deletions Modules/cmathmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,7 +829,7 @@ cmath_sqrt_impl(PyObject *module, Py_complex z)
ax = fabs(z.real);
ay = fabs(z.imag);

if (ax < DBL_MIN && ay < DBL_MIN && (ax > 0. || ay > 0.)) {
if (ax < DBL_MIN && ay < DBL_MIN) {
/* here we catch cases where hypot(ax, ay) is subnormal */
ax = ldexp(ax, CM_SCALE_UP);
s = ldexp(sqrt(ax + hypot(ax, ldexp(ay, CM_SCALE_UP))),
Expand Down Expand Up @@ -1013,7 +1013,7 @@ cmath_phase_impl(PyObject *module, Py_complex z)
double phi;

errno = 0;
phi = c_atan2(z);
phi = c_atan2(z); /* should not cause any exception */
if (errno != 0)
return math_error();
else
Expand Down